[
https://issues.apache.org/jira/browse/THRIFT-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683307#action_12683307
]
Michael Greene commented on THRIFT-380:
---------------------------------------
I'm not opposed to setuptools as I use it frequently myself, but I don't see
what the added dependency buys us here. easy_install & PyPI both work just
fine with distutils and sdist & bdist both produce individual files to
distribute comparable to eggs. If we were using pkg_resources or the plugin
entry points I would see the argument for a new dependency, but we are not. Is
there something I'm missing, or some other feature of setuptools that you're
planning on using in conjunction with this in the future that is unusable
without hard-coding the dependency in setup.py?
> Use setuptools for python build
> -------------------------------
>
> Key: THRIFT-380
> URL: https://issues.apache.org/jira/browse/THRIFT-380
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Reporter: Ben Maurer
>
> We should use setuptools for the python build as this allows thrift to be
> distributed as an egg file:
> {quote}
> Index: setup.py
> ===================================================================
> --- setup.py (revision 755803)
> +++ setup.py (working copy)
> @@ -5,9 +5,8 @@
> #
> # See accompanying file LICENSE or visit the Thrift site at:
> # http://developers.facebook.com/thrift/
> +from setuptools import setup, Extension
> -from distutils.core import setup, Extension
> fastbinarymod = Extension('thrift.protocol.fastbinary',
> sources = ['src/protocol/fastbinary.c'],
> )
> {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
