[
https://issues.apache.org/jira/browse/THRIFT-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683329#action_12683329
]
Michael Greene commented on THRIFT-380:
---------------------------------------
If it's just for getting something that you can dump onto PYTHONPATH, that
assumes that you as the distributor are in control of the build and can handle
the dependency. I would be in favor of optionally using setuptools without
depending on it, i.e.
{code}
try:
from setuptools import setup, Extension
except:
from distutils.core import setup, Extension
{code}
This should allow someone to still build from a tarball or fresh checkout
without having setuptools installed, but would also allow distributors to build
eggs as desired.
> Use setuptools for python build
> -------------------------------
>
> Key: THRIFT-380
> URL: https://issues.apache.org/jira/browse/THRIFT-380
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Reporter: Ben Maurer
>
> We should use setuptools for the python build as this allows thrift to be
> distributed as an egg file:
> {quote}
> Index: setup.py
> ===================================================================
> --- setup.py (revision 755803)
> +++ setup.py (working copy)
> @@ -5,9 +5,8 @@
> #
> # See accompanying file LICENSE or visit the Thrift site at:
> # http://developers.facebook.com/thrift/
> +from setuptools import setup, Extension
> -from distutils.core import setup, Extension
> fastbinarymod = Extension('thrift.protocol.fastbinary',
> sources = ['src/protocol/fastbinary.c'],
> )
> {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
