[ 
https://issues.apache.org/jira/browse/THRIFT-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jérémie BORDIER updated THRIFT-333:
-----------------------------------

    Attachment: THRIFT_333_CPP_Compact_Protocol.patch

Here's my first complete version. It's not fully tested but the tutorial passes 
well between Java/Cpp.

I'd like to get a review from David or Mark around the  doubleToLongBits and 
longBitsToDouble methods, i wonder if it's not the same that the 
bitwise_cast<T> you're using in BinaryProtocol to counter strict aliasing 
issues..

Also, if anyone has advice on the best and easiest way to integrate this 
protocol in a "generic protocol unit test", that'd be cool :-)

> Compact Protocol for C++
> ------------------------
>
>                 Key: THRIFT-333
>                 URL: https://issues.apache.org/jira/browse/THRIFT-333
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Library (C++)
>            Reporter: Bryan Duxbury
>            Assignee: Jérémie BORDIER
>            Priority: Trivial
>         Attachments: THRIFT_333_CPP_Compact_Protocol.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to