[ 
https://issues.apache.org/jira/browse/THRIFT-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Shigin updated THRIFT-333:
------------------------------------

    Attachment: q.cpp

I don't like an idea of temporary string in readBinary. std::string.assign 
works two time faster on my machine. Can anybody repeat the test?

{code}
$ g++ -Wall -O3 q.cpp
$ g++ --version
g++ (GCC) 4.2.1 20070719  [FreeBSD]
Copyright (C) 2007 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ time ./a.out | wc -l
    1000

real    0m3.622s
user    0m3.611s
sys     0m0.001s
$ time ./a.out x | wc -l
    1000

real    0m7.251s
user    0m3.962s
sys     0m3.269s
{code}

> Compact Protocol for C++
> ------------------------
>
>                 Key: THRIFT-333
>                 URL: https://issues.apache.org/jira/browse/THRIFT-333
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Library (C++)
>            Reporter: Bryan Duxbury
>            Assignee: Jérémie BORDIER
>            Priority: Trivial
>             Fix For: 0.1
>
>         Attachments: q.cpp, THRIFT_333_CPP_Compact_Protocol.patch, 
> THRIFT_333_CPP_Compact_Protocol.v2.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to