[
https://issues.apache.org/jira/browse/THRIFT-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688710#action_12688710
]
Bryan Duxbury commented on THRIFT-374:
--------------------------------------
I get a ton of "no method 'ord' for 2:Fixnum" when I run the specs. I think
this same problem might be affecting the nonblocking server tests.
As to the range checking you added - did you have to do this because the
behavior in 1.9 changed in some way in respect to pack? 1.8 would pack
oversized values for you, but truncates the excess. pack('c') will only write a
byte no matter what you put into it. If this is still the same behavior, I'd
love to remove the range checking and avoid that performance hit.
Other than the spec failures, the patch looks pretty good. If you can resolve
those failures I'll commit the patch.
> ruby 1.9 compatibility
> ----------------------
>
> Key: THRIFT-374
> URL: https://issues.apache.org/jira/browse/THRIFT-374
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Fix For: 0.1
>
> Attachments: thrift-374-v2.patch, thrift-374-v3.patch,
> thrift-374-v4.patch, thrift-374.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
