[ 
https://issues.apache.org/jira/browse/THRIFT-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688739#action_12688739
 ] 

Michael Stockton commented on THRIFT-374:
-----------------------------------------

That's interesting.  I would assume that you're running 1.8.7 or 1.9.1, but let 
me know if you're not.

irb(main):002:0> 1.class.name
=> "Fixnum"
irb(main):003:0> 1.ord
=> 1
irb(main):004:0> RUBY_VERSION
=> "1.8.7"

I added range checks because binaryprotocol_spec_shared checks that write_i32 
and write_i64 raise a RangeError if the value to pack is too big.  With 1.8.7, 
it appears this exception is raised by pack itself.  And, in 1.9.1, an 
exception is not raised. 




> ruby 1.9 compatibility
> ----------------------
>
>                 Key: THRIFT-374
>                 URL: https://issues.apache.org/jira/browse/THRIFT-374
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (Ruby)
>            Reporter: Michael Stockton
>            Assignee: Michael Stockton
>             Fix For: 0.1
>
>         Attachments: thrift-374-v2.patch, thrift-374-v3.patch, 
> thrift-374-v4.patch, thrift-374.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to