[
https://issues.apache.org/jira/browse/THRIFT-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rush Manbert updated THRIFT-591:
--------------------------------
Attachment: thriftWindowsRev818530BugFix.zip
These are modified files that fix 2 bugs I found in the code patch for Thrift
revision 818530.
Thrift.h fhas a really stupid bug that will corrupt the stack when an error is
reported in a Unix environment. I know that this patch is intended for use on
Windows, but it fully supports Unix as well and we use it there. I don't know
why I ever changed the buffer length, but I did and it was wrong and I'm sorry.
The two server socket files fix a race condition in the case where a server is
run as a separate thread in an application, and the server close() method is
called, or if the process finishes and the server socket destructor is called.
I have never seen this problem when running the Thrift stress test, which
explicitly closes the server socket connection in my version, but we saw a
problem here in a very unusual situation where the client side was doing
something strange at the same time.
You should replace your patched files with these versions. My apologies fort
any inconvenience.
> Make the C++ runtime library be compatible with Windows and Visual Studio
> -------------------------------------------------------------------------
>
> Key: THRIFT-591
> URL: https://issues.apache.org/jira/browse/THRIFT-591
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C++)
> Environment: Windows XP and above, Visual Studio 2005 and above
> Reporter: Rush Manbert
> Attachments: MsvcPatchSupportScripts.zip, thrift-818530-patched.zip,
> ThriftMsvcPatchForSvnRev818530.txt.zip, thriftWindowsRev818530BugFix.zip
>
>
> Modify the C++ runtime library to be compatible with Windows and able to be
> built by Visual Studio.
> The work has been done and a patch is available. I will attach it soon.
> Note that this issue and the attached patch supercedes the patches that I
> wrongly attached to JIRA 311. That issue is about making the C++ library
> support async client/server interaction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
