[
https://issues.apache.org/jira/browse/THRIFT-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier updated THRIFT-591:
-------------------------------
Attachment:
THRIFT-591_MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch_error.log
I would really like to have C++ Thrift runtime library on Windows, so I applied
the patch [^MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch] on Revision:
1005211.
But it does not apply cleanly, see
[^THRIFT-591_MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch_error.log]
>From my perspective this is a must for a *2.3 MB* patch, so currently a -1
>from my side.
issues and questions:
* patch should apply without any issue
* gen-cpp folders should not be a part of Thrift source
* why a new top level folder (msvc) for a language specific thing? e.g similar
lib/csharp/ThriftMSBuildTask/
* what about splitting the patch into several separate features? e.g.
** Local socket types, we have Unix Socket (THRIFT-900)
** boost asio support
** msvc support
** msvc tutorial
** probably there are better options to split...just a proposal
* etc.
> Make the C++ runtime library be compatible with Windows and Visual Studio
> -------------------------------------------------------------------------
>
> Key: THRIFT-591
> URL: https://issues.apache.org/jira/browse/THRIFT-591
> Project: Thrift
> Issue Type: New Feature
> Components: C++ - Library
> Environment: Windows XP and above, Visual Studio 2005 and above
> Reporter: Rush Manbert
> Attachments: MsvcPatchSupportScripts.zip,
> MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch,
> THRIFT-591_MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch_error.log,
> thrift-818530-patched.zip, ThriftMsvcPatchForSvnRev818530.txt.zip,
> thriftWindowsRev818530BugFix.zip
>
>
> Modify the C++ runtime library to be compatible with Windows and able to be
> built by Visual Studio.
> The work has been done and a patch is available. I will attach it soon.
> Note that this issue and the attached patch supercedes the patches that I
> wrongly attached to JIRA 311. That issue is about making the C++ library
> support async client/server interaction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
