[
https://issues.apache.org/jira/browse/THRIFT-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887946#action_12887946
]
Roger Meier commented on THRIFT-815:
------------------------------------
Hi Jordan!
code snippets? just use the question mark and preview function on the right
side of the input box to get help on formating text ;)
Cool, you did some tests with both patches and they work! What do you think
about the QUnit based test? Is there another framework you would recommend?
@Jake:
Could you commit the patch [THRIFT-815_thrift.js.patch |
https://issues.apache.org/jira/secure/attachment/12449170/THRIFT-815_thrift.js.patch]
, that fixes the wire order? ... I would like to commit, but I can't....
I would appreciate if you could commit the JavaScript test.html with the Unit
tests as well.
This might be a place where Jordan's likes to contribute?
Adding test cases for all defined functions at [ThriftTest.thrift
|https://svn.apache.org/repos/asf/incubator/thrift/trunk/test/ThriftTest.thrift]
is an important thing, for finding bugs inside the List<Object> serialization
and other.
Another BIG question is the server side for the tests, I use
test/cpp/srcTestServer.cpp using the C++ HttpServer, provided by THRIFT-247
(please commit...). It seems, that many different tests for several Languages
exist, but they do different things inside and are therefore not useful for
interacting with eachother.....I think this is an important thing to
standardize.
THRIFT-35 mentions that all language tests have to be moved into their
appropriate library directory, this will cleanup the test directory and it can
be used for describing standard tests cases, that have to be implemented in
every language.
> Deserialization of lists is critically broken.
> ----------------------------------------------
>
> Key: THRIFT-815
> URL: https://issues.apache.org/jira/browse/THRIFT-815
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (JavaScript)
> Affects Versions: 0.4
> Reporter: Jordan
> Assignee: T Jake Luciani
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 813-1.patch, test.html, THRIFT-815_thrift.js.patch
>
>
> Edit the test code that comes with the js language target:
> var list = [1,2,3];
> var ret = client.testList(list);
> debugger;
> ret comes back as [3,3,3] when it should be echoed back as [1,2,3]
> The test case never caught this because it only verified the size, and not
> the contents of the returned array.
> I cannot find an immediate workaround, but I will try wrapping it in a dummy
> type like ListServiceResponse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
