[
https://issues.apache.org/jira/browse/THRIFT-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888026#action_12888026
]
Roger Meier commented on THRIFT-815:
------------------------------------
Jordan,
my philosophy would be: *??Every thing that goes into the right direction and
fixes bugs should be commited.??*
Now Lists with simple types work properly with these patches. => That's a
*good* thing!
I really do not like to work with a local code base, that contains many
patches! see my *svn status*
{code}
M test/cpp/Thrift-test.mk
M test/cpp/src/TestClient.cpp
M test/cpp/src/main.cpp
M test/cpp/src/TestServer.cpp
M lib/cpp/src/protocol/TProtocol.h
A lib/cpp/src/transport/THttpServer.h
M lib/cpp/src/transport/THttpClient.cpp
M lib/cpp/src/transport/THttpClient.h
A lib/cpp/src/transport/THttpTransport.cpp
A lib/cpp/src/transport/THttpTransport.h
A lib/cpp/src/transport/THttpServer.cpp
M lib/cpp/Makefile.am
M lib/js/test/test.html
M lib/js/thrift.js
M compiler/cpp/src/generate/t_js_generator.cc
{code}
We should proceed with enhancing the Test Framework to have a good basis for
finding the pending bug's.
I'm especially interested in C++ and JavaScript bindings and I would like to
help fixing bugs and enhancing Thrift!
> Deserialization of lists is critically broken.
> ----------------------------------------------
>
> Key: THRIFT-815
> URL: https://issues.apache.org/jira/browse/THRIFT-815
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (JavaScript)
> Affects Versions: 0.4
> Reporter: Jordan
> Assignee: T Jake Luciani
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 813-1.patch, test.html, THRIFT-815_thrift.js.patch
>
>
> Edit the test code that comes with the js language target:
> var list = [1,2,3];
> var ret = client.testList(list);
> debugger;
> ret comes back as [3,3,3] when it should be echoed back as [1,2,3]
> The test case never caught this because it only verified the size, and not
> the contents of the returned array.
> I cannot find an immediate workaround, but I will try wrapping it in a dummy
> type like ListServiceResponse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
