[
https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899737#action_12899737
]
Anthony Molinaro commented on THRIFT-646:
-----------------------------------------
I could set the environment variable, but I sort of feel using erlang should
be as easy to use as perl and python (both of which figure out the appropriate
place to install on the system and put themselves there, but provide variable
to override those choices). I see looking at the m4 again that the
AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR does work with the ERLANG_INSTALL_LIB_DIR
environment variable. I just tried this
AC_ERLANG_PATH_ERL
AC_ERLANG_PATH_ERLC
AC_ERLANG_SUBST_LIB_DIR
ERLANG_INSTALL_LIB_DIR=${ERLANG_LIB_DIR}
AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR(AC_PACKAGE_NAME, AC_PACKAGE_VERSION)
which appears to work, but only with autoconf 2.65, 2.63 did not work. I guess
it's some sort of bug with 2.63.
Also for some reason even just doing
ERLANG_INSTALL_LIB_DIR=`$ERL -eval 'io:format("~s~n", @<:@code:lib_dir()@:>@)'
-s init stop -noshell`
failed in 2.63 but succeeded in 2.65. Changing $ERL to erl does seem to work
with 2.63 for whatever reason.
Seems like this is a somewhat known issue
https://support.process-one.net/browse/EXMPP-35?focusedCommentId=41182&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel
Anyway, that makes the overriding of the environment variable in configure.ac
seem sort of annoying.
What I had before doing this in the Makefile.am worked fine. You could guard a
little bit by changing my use of erl with $ERL but that may fail for some odd
reason as well.
Hmm, well, I still think it would be best if erlang installed itself in a place
it can just run, the Makefile.am way I had originally seems to work regardless
of autoconf version, so some variation of it might be best?
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.4
>
> Attachments: erl.patch, Makefile.am,
> v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which
> places things into the correct erlang library directory for the installed
> erlang. This means if someone has multiple erlangs install it will use
> whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize
> the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
