[ 
https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899957#action_12899957
 ] 

Anthony Molinaro commented on THRIFT-646:
-----------------------------------------

That works, I just created a small configure.ac with the lines in my last 
comment, then ran autoconf 2.63 on it, and checked that it failed.  Then 
updated to 2.65 reran autoconf, watched it succeed, then copied the configure 
script to a box with autoconf 2.59 and also watched it succeed.  So as long as 
we can guarantee the releaser is building with 2.65 or greater, I think we are 
good with adding

AC_ERLANG_SUBST_LIB_DIR
ERLANG_INSTALL_LIB_DIR=${ERLANG_LIB_DIR}

before the call to

AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR(AC_PACKAGE_NAME, AC_PACKAGE_VERSION)

> Erlang library is missing install target
> ----------------------------------------
>
>                 Key: THRIFT-646
>                 URL: https://issues.apache.org/jira/browse/THRIFT-646
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.2
>            Reporter: Anthony Molinaro
>            Assignee: David Reiss
>             Fix For: 0.4
>
>         Attachments: erl.patch, Makefile.am, 
> v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
>     echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which 
> places things into the correct erlang library directory for the installed 
> erlang.  This means if someone has multiple erlangs install it will use 
> whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize 
> the Makefile.am.
> The current lib/erl/Makefile should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to