[
https://issues.apache.org/jira/browse/THRIFT-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905946#action_12905946
]
David Reiss commented on THRIFT-698:
------------------------------------
I don't understand the .app stuff, so as long as it still builds and Todd has
no objections, I'm fine with this in principle.
I'm a bit worried that you moved some code from build into our Makefile.am.
Those files are LGPL licensed, so I'd prefer to keep them segregated if at all
possible. Worst case, I think it would be okay to have a single file for any
code you want to import from them and just use an include directive.
Including a BSD-licensed build script is fine.
> Generated module list should contain atoms, not strings
> -------------------------------------------------------
>
> Key: THRIFT-698
> URL: https://issues.apache.org/jira/browse/THRIFT-698
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
> Reporter: Roberto Aloi
> Assignee: Anthony Molinaro
> Attachments: erl-app.patch
>
>
> The generated list of modules in the .app file should contain atoms, not
> lists. Please refer to the official Erlang documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
