[ 
https://issues.apache.org/jira/browse/THRIFT-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905965#action_12905965
 ] 

Anthony Molinaro commented on THRIFT-698:
-----------------------------------------

Where is the license info for the stuff in build?  The only file I included was 
buildtargets.mk which only has a few things, and doesn't mention a license.  
However, if its cool to include BSD licensed build scripts, I'll probably 
refactor this in a different way.  I grab the good bits out of the framewerk 
erlang template, since it has a great way for running eunit tests, the dialyzer 
and code coverage.  It'll all tie into make check.

But it would be cool to just commit this, and then do that refactor.  So if the 
license is an issue for buildtargets.mk, I can leave that one file for a while, 
but I'd prefer to totally nuke that directory if possible, so if you have a 
pointer to license info so I can clarify that would be cool.

I'll open another task for additional refactoring.

> Generated module list should contain atoms, not strings
> -------------------------------------------------------
>
>                 Key: THRIFT-698
>                 URL: https://issues.apache.org/jira/browse/THRIFT-698
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Roberto Aloi
>            Assignee: Anthony Molinaro
>         Attachments: erl-app.patch
>
>
> The generated list of modules in the .app file should contain atoms, not 
> lists. Please refer to the official Erlang documentation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to