[
https://issues.apache.org/jira/browse/THRIFT-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908998#action_12908998
]
David Reiss commented on THRIFT-582:
------------------------------------
Based on my limited knowledge of glib, this looks good overall. I have a few
comments:
configure.ac:
I'm pretty sure autoscan is incorrect to request PROG_AWK and PROG_RANLIB.
Can you remove those?
Can you update the c_glib naming on AX_THRIFT_LIB and AX_THRIFT_GEN?
Also, can you add the c_glib binding to the summary printed out at the bottom?
I changed the style of the library checks a bit to make this work.
What is the source of the code used to enable coverage?
test/c:
Can you rename this to test/c_glib?
Makefile.in:
This should not be in the patch.
thrift_binary_protocol.c:
I think this line might cause problems with strict aliasing. See bitwise_cast
in the C++ codebase for more information.
guint64 bits = GUINT64_FROM_BE (*(unsigned long long *)&value);
Makefile.am:
no need for ACLOCAL_AMFLAGS anymore
Replace thriftc with thrift_c_glib
thriftc.pc:
Replace thriftc with thrift_c_glib
> C implementation of Thrift
> --------------------------
>
> Key: THRIFT-582
> URL: https://issues.apache.org/jira/browse/THRIFT-582
> Project: Thrift
> Issue Type: New Feature
> Reporter: David Reiss
> Assignee: Michael Lum
> Priority: Minor
> Attachments: c_glib_bindings.patch, t_c_generator.cc,
> thrift_582_c_glib_bindings.patch
>
>
> Create a usable implementation of Thrift that uses only C at runtime, no C++.
> The code is at
> http://svn.apache.org/repos/asf/incubator/thrift/branches/c-bindings/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
