[
https://issues.apache.org/jira/browse/THRIFT-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921084#action_12921084
]
Roger Meier commented on THRIFT-582:
------------------------------------
great job!
I think there are some minor issues to be solved before commit:
* I would like to see language specific tests in their appropriate library
directory THRIFT-35 (few languages are done, its easy to do for new ones)
* all unit test should pass without error
* It seems, that at least the unit tests depend on cpp implementation, what
about adding a dependancy on cpp inside configure.ac to ensure that we have
with-cpp?
{code}
./configure --without-csharp --without-java --without-erlang --without-perl
--without-php --without-php_extension --without-ruby --without-haskell
--without-python --without-cpp --with-c_glib
.....
g++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src -I./gen-cpp
-I../../lib/c_glib/src -I./gen-c -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -g -MT
testthrifttestclient-testthrifttestclient.o -MD -MP -MF
.deps/testthrifttestclient-testthrifttestclient.Tpo -c -o
testthrifttestclient-testthrifttestclient.o `test -f 'testthrifttestclient.cpp'
|| echo './'`testthrifttestclient.cpp
mv -f .deps/testthrifttestclient-testthrifttestclient.Tpo
.deps/testthrifttestclient-testthrifttestclient.Po
make[4]: *** No rule to make target `../../lib/cpp/.libs/libthrift.la', needed
by `testthrifttestclient'. Stop.
make[4]: Leaving directory
`/home/roger/software/thrift/thrift-trunk-c_glib/test/c_glib'
{code}
after configuring --with-cpp it nearly passes all unit tests.. but the
following 2 tests fail:
{code}
PASS: testdebugproto
/bin/sh: line 4: 21597 Segmentation fault ${dir}$tst
FAIL: testoptionalrequired
....
PASS: testwrapper-testdebugproto
./testwrapper-testoptionalrequired: line 7: 21888 Segmentation fault
"$stripcommand" "$@"
FAIL: testwrapper-testoptionalrequired
{code}
My Environment is: Debian GNU/Linux Lenny with
{code}
ii libglib2.0-0 2.16.6-3 The GLib
library of C routines
ii libglib2.0-dev 2.16.6-3 Development
files for the GLib library
ii gcc 4:4.3.2-2 The GNU C
compiler
ii gcc-4.3 4.3.2-1.1 The GNU C
compiler
ii gcc-4.3-base 4.3.2-1.1 The GNU
Compiler Collection (base package)
ii libtool 1.5.26-4+lenny1 Generic
library support script
{code}
> C implementation of Thrift
> --------------------------
>
> Key: THRIFT-582
> URL: https://issues.apache.org/jira/browse/THRIFT-582
> Project: Thrift
> Issue Type: New Feature
> Reporter: David Reiss
> Assignee: Michael Lum
> Priority: Minor
> Attachments: c_glib_bindings.patch, t_c_generator.cc,
> thrift_582_c_glib_bindings.patch, thrift_582_c_glib_bindings_20100927.patch,
> thrift_582_c_glib_bindings_20101012.patch
>
>
> Create a usable implementation of Thrift that uses only C at runtime, no C++.
> The code is at
> http://svn.apache.org/repos/asf/incubator/thrift/branches/c-bindings/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
