[
https://issues.apache.org/jira/browse/THRIFT-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915024#action_12915024
]
Roger Meier commented on THRIFT-920:
------------------------------------
Christian, I had a look on your patch. It work's.
I'm not sure if this is the proper solution:
- remove _using namespace boost;_ from TestServer.cpp and use
_boost::shared_ptr_ instead of _shared_ptr_
- using string without namespace prefix works on other files you use as well
could you please use the original patch and add the following include to
TestServer.cpp:
{code}
#include <boost/shared_ptr.hpp>
// maybe also
#include <string>
{code}
> C++ Test and Tutorial does not compile anymore due to the change within Enum
> handling
> -------------------------------------------------------------------------------------
>
> Key: THRIFT-920
> URL: https://issues.apache.org/jira/browse/THRIFT-920
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library, Test Suite
> Affects Versions: 0.5
> Reporter: Roger Meier
> Fix For: 0.5
>
> Attachments:
> THRIFT-920_cpp_fix_enum_change_on_test_and_tutorial.patch,
> v2-thrift-fix-cpp-test.patch
>
>
> This patch changes the following files, to support the new more powerful
> enumeration handling introduced since 0.4.0
> {code}
> M test/cpp/Thrift-test.mk
> M test/cpp/src/TestClient.cpp
> M test/cpp/src/TestServer.cpp
> M tutorial/cpp/CppClient.cpp
> M tutorial/cpp/CppServer.cpp
> {code}
> changes e.g.
> {code}
> - crazy.userMap.insert(make_pair(EIGHT, 8));
> + crazy.userMap.insert(make_pair(Numberz::EIGHT, 8));
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
