[ 
https://issues.apache.org/jira/browse/THRIFT-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roger Meier updated THRIFT-920:
-------------------------------

    Attachment: THRIFT-920_cpp_fix_enum_change_on_test_and_tutorial.v3.patch

Yes, there are probably too many _using namespace_  clauses.

This patch is just a little fix, so that stuff gets compiled again. I just 
added a new patch to solve your issue as well: 
{code}
-  } catch (exception& e) {
+  } catch (std::exception& e) {
{code}

Anyway, TestServer and TestClient need some rework to become real unit tests by 
using boost unit test framework.
and thats probably the time to cleanup these things you mentioned.


> C++ Test and Tutorial does not compile anymore due to the change within Enum 
> handling
> -------------------------------------------------------------------------------------
>
>                 Key: THRIFT-920
>                 URL: https://issues.apache.org/jira/browse/THRIFT-920
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library, Test Suite
>    Affects Versions: 0.5
>            Reporter: Roger Meier
>             Fix For: 0.5
>
>         Attachments: 
> THRIFT-920_cpp_fix_enum_change_on_test_and_tutorial.patch, 
> THRIFT-920_cpp_fix_enum_change_on_test_and_tutorial.v3.patch, 
> v2-thrift-fix-cpp-test.patch
>
>
> This patch changes the following files, to support the new more powerful 
> enumeration handling introduced since 0.4.0
> {code}
> M      test/cpp/Thrift-test.mk
> M      test/cpp/src/TestClient.cpp
> M      test/cpp/src/TestServer.cpp
> M      tutorial/cpp/CppClient.cpp
> M      tutorial/cpp/CppServer.cpp
> {code}
> changes e.g.
> {code}
> -    crazy.userMap.insert(make_pair(EIGHT, 8));
> +    crazy.userMap.insert(make_pair(Numberz::EIGHT, 8));
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to