Ton, Thanks for trying it out so hard! After seeing your result, I figured that I wouldn't want to use it that way myself. So I changed the codes to better support multiple transclusion. Seems to work within my tests. I will put it on soon for interested people to try and see.
Thanks again for the always useful feedback! Vincent On Monday, September 10, 2012 7:28:25 PM UTC+8, TonG wrote: > > Hi Vincent, > > Your precondition of "ONE transclusion macro - one <<tiddler ...>> > macro or one <<tabs ...>> macro - in ONE tiddler" sounded very logical > to me given the explanation in > http://twtable.tiddlyspace.com/#TableEditor--Example--IssueWithTransclusion > Your example showed me yesterday that only the first table (from the > first transcluded tiddler) can be edited; I could not edit the second > table (at least I thought so). > But today I can edit the second table of your example (win 7, FF 15, > IE 9, Chrome 17 portable)! > > So I made a Minimal Test Case [1] > I could "edit" all tables in a tiddler with two <<tabs ...>> macros in > it. > But there is an issue: If you do not switch the tabs in the second > <<tabs ...>> macro BEFORE edting, you cannot edit the first row of the > table in this second <<tab ...>>> macro and upon editing cells in > other rows the cell contains the value of the cell above the edited > cell (upon saving values are sometimes saved in the 'wrong' cell). > So switching tabs in the second <<tabs ...>> macro is essential for > "correct" editing. > > I could also edit all tables in a tiddler with four <<tiddler ...>>> > macros in it. > But there is an issue as well: you cannot edit the first row of the > table in the last three <<tiddler ...>>> macros and upon editing cells > in other rows the cell contains the value of the cell above the edited > cell. > I could not find a trick as with the <<tabs ...>> macro. > > Note that the tables in the transcluded tiddlers are numbered Table 0, > Table 1, Table 2, Table 3 (in your example > http://twtable.tiddlyspace.com/#TableEditor--Example--IssueWithTransclusion > both are labeled Table 0). > > Test conditions for the MTC: Win 7, FF 15, IE 9, Chrome 17 portable. > > Cheers, > > Ton > > > On Sep 10, 12:36 am, Yakov <yakov.litvin.publi...@gmail.com> wrote: > > Vincent, > > > > thank you so much! This is indeed a much-and-long-needed plugin. I > tested a > > bit in Android, it even works there in both AndTidWiki and FireFox 15! > > > > Couple of notes: > > > > * there's an inconvenient behavior of editable (because of "editable" > class > > or chkTEditorAllTableEditable) tables without a given caption. Browsers > are > > separated in the following two groups: Opera, FireFox (including FF for > > Android), IE create a "nonpresistent" caption "Table 1" etc ("Table 2", > if > > there are two such tables) which is just displayed with the "E" button > but > > which is not stored (if, for instance, chkTEditorAllTableEditable is > > changed to false, such caption dissapear); while Chrome and Safari (and > > AndTidWiki) don't create such caption and don't create the "E" button as > > well. It would be more convenient if in such case each browser creates > an > > empty caption (or a caption with " " content which is not visible). > > > > * may be it's not consistent mentioning this as you already discuss > copying > > and pasting colomns, but a useful (and probably not difficult to > implement) > > feature would be shifting colomns left and right (such buttons can be > added > > besides those "insert colomn left/right" in the same menu). This is > > especially useful in tables created for comparison of things. > > > > * in Android, there are some problems with row/colomn menus: > > ** once a (say, colomn) menu appears, I can't make it disappear, only > > substitute it with the menu of another colomn (would be nice to make it > > disappear by tapping somewhere outside the table) > > ** there's a bug with row menus in AndTidWiki, it behaves in the > following > > way: tiddler content: > > > > |table 1|c > > |editable|k > > |h-cell1|h-cell2||h > > |c11|c12+|| > > |c21|c22|| > > > > when entering the edit mode, a menu of (~nonexisting) row (effectively > of > > the line after the last row) appears without me tapping anywhere; > clicking > > the "add row below" button adds a "row" outside the talbe, with a blank > > line of space between it and the table, if such space line was present, > and > > adds a row after the last row of the table one otherwise; clicking "add > row > > above" creates a row after the last one in any case; "delete row" button > > deletes the line after the table if it is present, or does nothing > > otherwise. > > > > It's really nice that each time I open TW google group, there's > something > > new and sometimes incredibly useful, or at least interesting questions > to > > answer.. Thanks again, > > > > Best regards, > > Yakov. > > > > воскресенье, 9 сентября 2012 г., 14:30:34 UTC+4 пользователь Vincent Yeh > > написал: > > > > > > > > > > > > > > > > > > > > > Ton, > > > > > Thanks a lot. The TabEditPlugin did give me a good idea about how to > do. > > > > > TableEditor v1.3.4 > > > > > minimized version:http://twtable.tiddlyspace.com/#TableEditor--MIN > > > full version:http://twtable.tiddlyspace.com/#TableEditor > > > > > The main change is *transclusion support*: it is *now possible to edit > a > > > transcluded table loaded with <<tabs ...>> or <<tiddler ...>> macros*. > > > > > Examples: > > > > > 1.http://twtable.tiddlyspace.com/#TableEditor--Example--TabsMacro > > > 2. > http://twtable.tiddlyspace.com/#TableEditor--Example--TiddlerMacro > > > > > Things work fine with ONE transclusion macro - one <<tiddler ...>> > macro > > > or one <<tabs ...>> macro - in ONE tiddler. *More than one > transclusion > > > macros in the same tiddler will confuse the TableEditor*. See > > > > http://twtable.tiddlyspace.com/#TableEditor--Example--IssueWithTransc...details. > > > > > > > Vincent > -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To view this discussion on the web visit https://groups.google.com/d/msg/tiddlywiki/-/WN3kaPlY8ZUJ. To post to this group, send email to tiddlywiki@googlegroups.com. To unsubscribe from this group, send email to tiddlywiki+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/tiddlywiki?hl=en.
