Hi Simon

> and it does what I expect from this, it adds the class to the body if 
> fullscreen.
> 
> could this be implemented correctly in the core?

A change along those lines wouldn’t cover the situation where the user uses a 
browser control like the F11 key to enter full screen mode.

It appears that this is one of those tricky challenges in web development, and 
there may not be a good solution:

https://stackoverflow.com/questions/21461890/browser-f11-fullscreen-does-not-register-with-webkit-full-screen-or-javascript
 
<https://stackoverflow.com/questions/21461890/browser-f11-fullscreen-does-not-register-with-webkit-full-screen-or-javascript>

If there is a workable solution out there I’d be happy to accept a pull request,

Best wishes

Jeremy.


> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to tiddlywikidev+unsubscr...@googlegroups.com 
> <mailto:tiddlywikidev+unsubscr...@googlegroups.com>.
> To post to this group, send email to tiddlywikidev@googlegroups.com 
> <mailto:tiddlywikidev@googlegroups.com>.
> Visit this group at https://groups.google.com/group/tiddlywikidev 
> <https://groups.google.com/group/tiddlywikidev>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywikidev/30ea0b01-7601-4436-ac0d-e047b1a45105%40googlegroups.com
>  
> <https://groups.google.com/d/msgid/tiddlywikidev/30ea0b01-7601-4436-ac0d-e047b1a45105%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout 
> <https://groups.google.com/d/optout>.

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/D5AEF1DA-9875-49F4-A654-6393CCFE1BB1%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to