@stevekennedyuk commented on this pull request.
> @@ -670,18 +683,35 @@
retry = 10;
while ((ret_size < sizeof(struct protocol)) && (retry >
0)) {
- ret_size = recv(pfd, resp + ret_size,
(sizeof(struct protocol)
- -
ret_size), 0);
+ ssize_t n = recv(pfd, (char *)resp + ret_size,
False positive: Flawfinder flags every `recv()` call. This one reads into the
fixed-size `struct protocol` and is bounded by `sizeof(struct protocol) -
ret_size`, so it can't overrun, and the loop it replaces already called
`recv()` on the same socket.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/mod_tile/pull/503#discussion_r4261656364
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/mod_tile/pull/503/review/[email protected]>_______________________________________________
Tile-serving mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/tile-serving
