On 12/13/2016 10:03 PM, Jon Maloy wrote: >> I still prefer to use "tipc_u32" prefix because the function names are a >> > bit too generic without "tipc". Especially when we analyze stack trace, >> > common function names cause a bit inconvenience for us. > That is what I used first, but some code lines became awkwardly long, so I > had to split if-clauses and function calls over two lines, something I > generally try to avoid. > Also, remember that this is an internal function that is only called from > other functions having the "tipc_" prefix, so you will never be in in doubt > where the problem is if you see a stack dump. >
OK, it's fine with me. Acked-by: Ying Xue <[email protected]> > ///jon > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
