On Sat, May 18, 2013 at 03:35:44AM -0500, J Raynor wrote: > The patch I had sent in was meant for testing, and to see if there was > any interest, so I wasn't putting any effort into getting it into > shape for acceptance. Now that that might be possible, I'll get it > cleaned up, taking into account your notes. > > > > I guess this obviously won't let other things that need file descriptor > > passing work like "loadb -" or "saveb -". > > I wasn't aware that load or saveb passed file descriptors. The > functionality appears to work.
Oh they used to but they don't anymore, sorry. > > Why do you need to dup stdin in the client? > > Where are you seeing the dup? My patch removed a dup in client.c, but > that'll have to be skipped conditionally since non-cygwin clients will > need to continue doing it. Ok I misread the diff. Yes put that under #ifdef. Next time can you send a unified diff (diff -u) instead as it's much easier to read? > > Can you replace cyg_get_identify_fd by just putting the one line under > > #ifdef WIN32? > > > Is WIN32 the right thing to be checking for? Would it be better to > check for _CYGWIN_ instead so that it works on WIN64 as well? I think it's actually _WIN32, and it is defined on both 32-bit and 64-bit Windows. But use a Cygwin define if you prefer, I don't mind. > > > > Likewise the resolv.h change should go into compat.h. And why do you > need to define ECHOPRT? > > The ncurses.h supplied by cygwin doesn't define ECHOPRT, so > compilation fails when it is referenced in tty.c. That should also go in compat.h under an #ifndef ECHOPRT. ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
