Yes it will have to be a stub, fcntl is useless too.

-------- Original message --------
From: Dagobert Michelsen <d...@opencsw.org> 
Date: 11/08/2014  08:56  (GMT+00:00) 
To: Nicholas Marriott <nicholas.marri...@gmail.com> 
Cc: tmux-users@lists.sourceforge.net 
Subject: Re: flock again 
 
Hi Nicholas,

Am 10.08.2014 um 10:54 schrieb Nicholas Marriott <nicholas.marri...@gmail.com>:
> lockf and fcntl are broken (any close on the fd releases all locks) so I 
> suggest the best option is to create an flock in compat/ that is a no-op and 
> do without the locking on Solaris.
> Or there may be a locking function that has the semantics we need.

I guess there is only posix-conforming (and therefore „broken“) locking
available on Solaris. However, I found this post from a guy changing
the locking (in a probably broken way) in tmux:
  http://www.perkin.org.uk/posts/solaris-portability-flock.html
Am I right to assume that you suggest to replace the above approach with
the empty compat stub only put in place on Solaris?


Best regards

  — Dago

> 
> 
> 
> -------- Original message --------
> From: Dagobert Michelsen <d...@opencsw.org> 
> Date: 10/08/2014 08:13 (GMT+00:00) 
> To: tmux-users@lists.sourceforge.net 
> Subject: flock again 
> 
> 
> Hi,
> 
> I just noticed my continous builds on Solaris failed for tmux HEAD with 
> missing flock definition
>   
>https://buildfarm.opencsw.org/buildbot/builders/tmux-solaris10-sparc/builds/59/steps/shell_2/logs/stdio
> similar to the one we fixed some time ago:
>   http://sourceforge.net/p/tmux/tmux-code/merge-requests/1/
> 
> Commits are automatically picked up, you can verify the current state at
>   
>https://buildfarm.opencsw.org/buildbot/waterfall?builder=tmux-solaris10-i386&builder=tmux-solaris10-sparc&reload=none
> 
> 
> Best regards
> 
>   -- Dago
> ------------------------------------------------------------------------------
> _______________________________________________
> tmux-users mailing list
> tmux-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tmux-users

-- 
"You don't become great by trying to be great, you become great by wanting to 
do something,
and then doing it so hard that you become great in the process." - xkcd #896

------------------------------------------------------------------------------
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users

Reply via email to