Would you terribly mind to make this change and push it ? I'd like it to go into the today's upstream submission.
Alex On Wed, Mar 12, 2014 at 3:10 PM, Amit Kumar Chaudhary < [email protected]> wrote: > Hi Alex, > > On 12 March 2014 at 8:25:16 pm, Damian, Alexandru ( > [email protected]) wrote: > > Hello Amit, > > Regarding patch on head of > contrib/achaudhary/errors_warnings_ondashboard_v4 > > I am not sure why you add Javascript code inside "base.html" that only > works on the "builddashboard.html" page. Are the classes and identifiers > reused elsewhere ? > > No, not at the moment, I wasn’t sure about its placement, but it did look > like something that could be used again. > > > > If not, the javascript code should be in the same file as the elements it > changes. > > Yes, seems correct. > > Thanks, > > —amit > > > > Cheers, > Alex > > > > On Mon, Mar 10, 2014 at 1:31 PM, Amit Kumar Chaudhary < > [email protected]> wrote: > >> Hi David, >> >> Thanks. Fixed it, the branch containing the revised patch is available as >> achaudhary/errors_warnings_ondashboard_v4. >> >> The smaller patch that makes this particular edit is also available, at >> the tip of _v3. >> >> —amit >> >> >> On 7 March 2014 at 7:05:32 pm, Reyna, David ([email protected]) >> wrote: >> >> Hi Amit, >> >> >> >> Thanks. By the way, I am getting an error from HTML Validator saying that >> the “name” attributes are not longer allowed in <div>’s for HTML5. >> >> >> >> +<div class="accordion span10 pull-right" id="errors" name="errors"> >> >> --------------------------------------------------------^^^^^^^^^^^^^ >> >> >> >> +<div class="accordion span10 pull-right" id="warnings" name="warnings"> >> >> ----------------------------------------------------------^^^^^^^^^^^^^ >> >> >> >> I also had to remove those when I picked them up from Belen’s sample code >> for my recipe detail page. >> >> >> >> - David >> >> >> >> *From:* Amit Kumar Chaudhary [mailto:[email protected]] >> >> *Sent:* Friday, March 07, 2014 4:26 AM >> *To:* Reyna, David; Wymore, Farrell; BARROS PENA, BELEN >> *Cc:* '[email protected]' >> *Subject:* Re: [Toaster] toaster: review request for build dash board >> page >> >> >> >> Hi David, >> >> >> >> This was just a trial review. We are waiting for your commit to be pushed >> so that we can properly merge with it, as per my request. In our Wednesday >> call. >> >> I think I missed that part, but I do remember saying ok to rebasing the >> code to the latest toaster/master. I have done that now and it is available >> at >> >> achaudhary/errors_warnings_ondashboard_v3 >> >> Thanks, >> >> —amit >> >> >> -- >> _______________________________________________ >> toaster mailing list >> [email protected] >> https://lists.yoctoproject.org/listinfo/toaster >> >> > > > -- > Alex Damian > Yocto Project > SSG / OTC > > -- Alex Damian Yocto Project SSG / OTC
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
