Edited subject line to have [review-request] in it, to make it filter friendly.
-- Amit Kumar Chaudhary On 19 March 2014 at 5:13:13 pm, Amit Kumar Chaudhary ([email protected]) wrote: Hi Belen, Fixed this one, combined the two calls into one, patch is available at achaudhary/combine_ready_calls Thanks, -- Amit Kumar Chaudhary On 12 March 2014 at 11:50:22 pm, Barros Pena, Belen ([email protected]) wrote: On 12/03/2014 18:13, "Amit Kumar Chaudhary" <[email protected]> wrote: > >Hi Alex, Belen, > > >Thanks, that¹s where I have added it, pushed the branch to >achaudhary/errors_warnings_ondashboard_v6. Hi Amit, This is looking good, although you don't need lines 95 and 113, since there is already a $(document).ready(function(){}); block in the script. You just need to paste the additional lines inside it. Cheers Belén > > > > >-- >Amit Kumar Chaudhary > > > >On 12 March 2014 at 11:33:50 pm, Damian, Alexandru >([email protected]) wrote: > >this is also a good solution :) > >Alex > > > > >On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen ><[email protected]> wrote: > >On 12/03/2014 15:10, "Amit Kumar Chaudhary" <[email protected]> >wrote: >> >>If not, the javascript code should be in the same file as the elements it >>changes. > > >FWIW, I have been putting all javascript code in static/js/main.js > >Cheers, > >Belén > > > > > > > >-- >Alex Damian >Yocto Project > >SSG / OTC > > > > > >
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
