The patch was sent as an attachment.
Here it is again, this time as "diff -u" instead of "diff -c"
and I have forced it to plain text only instead of both plain text
and html.
Hopefully that will come through ok.
Let me know if you still have any problems.
Shawn
Marc Saegesser wrote:
> Shawn,
>
> Would you please re-post the patch. Provide the output of cvs diff -u as an
> attachment this time. Your previous post included the patch embedded inside
> the email (which was HTML formatted) and was almost unreadable.
>
> -----Original Message-----
> From: Shawn McMurdo [mailto:[EMAIL PROTECTED]]
> Sent: Tuesday, January 02, 2001 1:03 PM
> To: [EMAIL PROTECTED]
> Subject: Re: The significance of root context
>
> Did you see my patch submitted to the list on 2000 Dec 23?
> I think it addresses this problem.
> Shawn
> David Soroko wrote:
> Thanks --
> ============================================
> David Soroko
> mailto:[EMAIL PROTECTED]
> http://www.geocities.com/SiliconValley/Campus/1628/
> Manna Inc.
> ============================================
>
> -----Original Message-----
> From: Thom Park [mailto:[EMAIL PROTECTED]]
> Sent: Tuesday, January 02, 2001 1:42 AM
> To: [EMAIL PROTECTED]
> Subject: Re: The significance of root context
>
> This is a known bug in tomcat and is documented in the release notes - I got
> bit by this one as well ;-)
> -T.
> David Soroko wrote:
> I am trying to understand the significance of the "root" context in TC 3.2.
> It seems that when no root context is defined i.e. when nothing is mapped to
> "" path and
> an unavailable resource is requested by a client, tomcat takes up 100% CPU
> time and does not let go.
> Must I always map some directory to the root context?
>
> Steps to reproduce behavior in the standard TC 3.2 distribution:
> * In server.xml comment out
> <ContextInterceptor className="org.apache.tomcat.context.AutoSetup" />
> (this has the effect that the webapps/ROOT is not mapped to "").
> * Start TC
> * Connect to http://localhost:8080
> Note: the same behavior can be seen if webapps/ROOT is removed.
>
> --
> ============================================
> David Soroko
> mailto:[EMAIL PROTECTED]
> http://www.geocities.com/SiliconValley/Campus/1628/
> Manna Inc.
> ============================================
> --
> Shawn McMurdo mailto:[EMAIL PROTECTED]
> Lutris Technologies http://www.lutris.com
> Enhydra.Org http://www.enhydra.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, email: [EMAIL PROTECTED]
--
Shawn McMurdo mailto:[EMAIL PROTECTED]
Lutris Technologies http://www.lutris.com
Enhydra.Org http://www.enhydra.org
Index: ContextManager.java
===================================================================
RCS file:
/home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/core/ContextManager.java,v
retrieving revision 1.100.2.19
diff -u -r1.100.2.19 ContextManager.java
--- ContextManager.java 2000/11/16 18:25:21 1.100.2.19
+++ ContextManager.java 2001/01/03 21:22:48
@@ -1015,6 +1015,29 @@
Context ctx = req.getContext();
if(ctx==null) ctx=getContext("");
+ // XXX We handle this case specially
+ if (ctx == null) {
+ try {
+ res.setContentType("text/html");
+ String body = "<html><head><title>Not
+found!</title></head><body><h2>Not found!</h2></body></html>";
+ res.setContentLength(body.length());
+ if (res.isUsingStream()) {
+ ServletOutputStream out = res.getOutputStream();
+ out.print(body);
+ out.flush();
+ } else {
+ PrintWriter out = res.getWriter();
+ out.print(body);
+ out.flush();
+ }
+ return;
+ } catch (IOException ioe) {
+ // XXX ignore, we tried
+ //ioe.printStackTrace();
+ return;
+ }
+ }
+
// don't log normal cases ( redirect and need_auth ), they are not
// error
// XXX this log was intended to debug the status code generation.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
