One more thing, should we add a ClusterBase class too, to enable a cluster to become an MBean by default? I assume we could put in all the JMX methods in there, because today, I only implement the Cluster interface in my class.
Filip > -----Original Message----- > From: Filip Hanik > Sent: Monday, March 17, 2003 12:35 PM > To: Tomcat Developers List > Subject: RE: cvs commit: > jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session > ManagerBase.java > > > thanks a bunch > > > -----Original Message----- > > From: Costin Manolache [mailto:[EMAIL PROTECTED] > > Sent: Monday, March 17, 2003 12:32 PM > > To: [EMAIL PROTECTED] > > Subject: RE: cvs commit: > > > jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session > > ManagerBase.java > > > > > > Filip Hanik wrote: > > > > > Hi Costin, > > > haven't had time to review these changes, will they affect > > the clustering > > > implementation of the manager that extends > StandardManager in there? > > > > Just make sure start() calls super.start(), or has: > > if( ! initialized ) > > super.init() > > > > You may want to add a file "mbeans-descripors.xml" in the > > same package - > > with the attributes and operations you want to expose and their > > description. This is optional - if you don't, introspection > > will be used > > and all simple attributes and operations will be exposed ( but no > > description ) > > > > Costin > > > > > > > > > > Filip > > > > > >> -----Original Message----- > > >> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > >> Sent: Monday, March 17, 2003 11:25 AM > > >> To: [EMAIL PROTECTED] > > >> Subject: cvs commit: > > >> > > > jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session > > >> ManagerBase.java > > >> > > >> > > >> costin 2003/03/17 11:24:35 > > >> > > >> Modified: catalina/src/share/org/apache/catalina/session > > >> ManagerBase.java > > >> Log: > > >> Registration > > >> > > >> Revision Changes Path > > >> 1.14 +33 -2 > > >> jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina > > >> /session/ManagerBase.java > > >> > > >> Index: ManagerBase.java > > >> > > =================================================================== > > >> RCS file: > > >> /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apach > > > e/catalina/session/ManagerBase.java,v > > >> retrieving revision 1.13 > > >> retrieving revision 1.14 > > >> diff -u -r1.13 -r1.14 > > >> --- ManagerBase.java 21 Jan 2003 00:43:18 -0000 1.13 > > >> +++ ManagerBase.java 17 Mar 2003 19:24:35 -0000 1.14 > > >> @@ -87,9 +87,12 @@ > > >> import org.apache.catalina.Engine; > > >> import org.apache.catalina.Manager; > > >> import org.apache.catalina.Session; > > >> +import org.apache.catalina.core.StandardContext; > > >> +import org.apache.catalina.core.StandardHost; > > >> import org.apache.catalina.util.StringManager; > > >> import org.apache.commons.logging.Log; > > >> import org.apache.commons.logging.LogFactory; > > >> +import org.apache.commons.modeler.Registry; > > >> > > >> > > >> /** > > >> @@ -223,6 +226,8 @@ > > >> // number of duplicated session ids - anything >0 > > >> means we have problems > > >> protected int duplicates=0; > > >> > > >> + protected boolean initialized=false; > > >> + > > >> /** > > >> * The string manager for this package. > > >> */ > > >> @@ -603,7 +608,33 @@ > > >> > > >> > > >> // > > >> --------------------------------------------------------- > > >> Public Methods > > >> - > > >> + public void destroy() { > > >> + if( oname != null ) > > >> + Registry.getRegistry().unregisterComponent(oname); > > >> + initialized=false; > > >> + } > > >> + > > >> + public void init() { > > >> + if( initialized ) return; > > >> + initialized=true; > > >> + > > >> + if( oname==null ) { > > >> + try { > > >> + StandardContext > > >> ctx=(StandardContext)this.getContainer(); > > >> + Engine > eng=(Engine)ctx.getParent().getParent(); > > >> + domain=eng.getName(); > > >> + StandardHost > hst=(StandardHost)ctx.getParent(); > > >> + > > >> + oname=new ObjectName(domain + > > ":type=Manager,path=" > > >> + + ctx.getPath() + ",host=" + hst.getName()); > > >> + > > >> Registry.getRegistry().registerComponent(this, oname, null ); > > >> + } catch (Exception e) { > > >> + log.error("Error registering ",e); > > >> + } > > >> + } > > >> + log.info("Registering " + oname ); > > >> + > > >> + } > > >> > > >> /** > > >> * Add this Session to the set of active Sessions for > > >> this Manager. > > >> > > >> > > >> > > >> > > >> > > > --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > > >> For additional commands, e-mail: > [EMAIL PROTECTED] > > >> > > >> > > >> > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
