I'm +1 for this as well and would like to get a fix in for the Apache modules. I will be happy to build and post NetWare modules in either case.
I wanted to run my fix by Henri (and anyone else interested) first since he made the change based on a patch sent in. Basically, the change was how mod_jk is filling in the port. The change was from apr_sockaddr_port_get(&port, r->connection->local_addr) (at least in the Apache 2 version - something similar in Apache 1.3) to ap_get_server_port(r). The comment says something about /* XXX: à la jk2 */ but when I looked in the jk2 code, it is still doing it the old way (looking in JTC/jk/native2/server/apache2/jk_service_apache2.c). In my testing, the new way only returns the default port for the server (i.e. the first Listen/Port directive) unless a VirtualHost section exists. If I have multiple ports opened that are providing the same content without an explicit VirtualHost (very common on NetWare for 80 and 443), the ap_get_server_port always returns 80 (or whatever the default port is). the apr_sockaddr_port_get appears to always return the correct port reguardless of whether or not there is a VirtualHost defined. To make a long story short, I'd like to put this back to the original call which had the comment /* get the real port (otherwise redirect failed) */. This has actually been validated in my testing. I just didn't want to break someone else if there was a different reason for the patch. Thanks, Mike Anderson >>> [EMAIL PROTECTED] 3/17/2003 6:50:31 AM >>> Thanks. It isn't ready yet. I tried over the weekend running Apache 2/mod_jk-1.2.3-dev on a production site. With my recent commits it is running much better, but it is still failing at least once a day. Argh! I'll have to go back once again and see if I can reproduce the failure on a test system. Glenn Henri Gomez wrote: > Glenn Nielsen wrote: > >> >> >> Henri Gomez wrote: >> >>> Glenn Nielsen wrote: >>> >>>> It has been a while since a mod_jk 1.2 release was done. >>>> There have been a number of bug fixes and a few minor feature >>>> enhancements. >>>> >>>> I just did some commits to fix some bugs I was seeing with mod_jk >>>> 1.2 and >>>> Apache 2.0. Some of these will also improve the connector for other >>>> web >>>> servers. (Better handling of aborted clients) >>>> >>>> I just upgraded one of our production sites from Apache 1.3 mod_jk >>>> 1.2.2 to >>>> Apache 2.0 mod_jk 1.2.3-dev. So far everything is looking good. >>>> >>>> I really wanted to add support for using the APR to implement a global >>>> tomcat socket connector pool. There just doesn't seem to be any easy >>>> way to do it without major code refactoring. Argh! >>> >>> >>> >>> >>> JK2 is our target, with APR +/- mandatory. >>> >>>> Perhaps we could do a mod_jk 1.2.3 release in two weeks or so? >>>> >>>> That should give adequate time for testing. >>> >>> >>> >>> >>> +0 >>> >>> Good idea but don't have time to do the RI. >>> >>> Would you like doing it ? >>> >> >> What is required to do the release? Do you have any notes on how to do >> connector releases? > > > The usual part are : > > - tag JTC > > - make a source tarball, and keep only jk related stuff > (see the contents of jk 1.2.2 tarball) > > - make binaries (I'll do the linux, may be Nacho or Mladen could make > the windows/IIS and Mike Anderson the netware. > > - Make the announce. > >> The only platforms I could build binaries for is Solaris 7/8 x86/sparc. >> >> Regards, >> >> Glenn >> >> ---------------------------------------------------------------------- >> Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder | >> MOREnet System Programming | * if iz ina coment. | >> Missouri Research and Education Network | */ | >> ---------------------------------------------------------------------- >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
