remm 2003/07/07 23:30:45
Modified: modules/cluster/src/share/org/apache/catalina/cluster/session
SimpleTcpReplicationManager.java
Log:
- Remove session recycling, as well as the comments criticizing session
recycling.
Revision Changes Path
1.9 +4 -26
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/SimpleTcpReplicationManager.java
Index: SimpleTcpReplicationManager.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/SimpleTcpReplicationManager.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- SimpleTcpReplicationManager.java 18 Apr 2003 02:51:24 -0000 1.8
+++ SimpleTcpReplicationManager.java 8 Jul 2003 06:30:45 -0000 1.9
@@ -229,29 +229,7 @@
throw new
IllegalStateException(sm.getString("standardManager.createSession.ise"));
- // Recycle or create a Session instance
- Session session = null;
- //modified to make sure we only recycle sessions that are of
type=ReplicatedSession
- //I personally believe the VM does a much better job pooling object
instances
- //than the synchronized penalty gives us
- synchronized (recycled) {
- int size = recycled.size();
- int index = size;
- if (size > 0) {
- do
- {
- index--;
- session = (Session) recycled.get(index);
- recycled.remove(index);
- } while ( index > 0 && (session instanceof ReplicatedSession));
- }
- }//synchronized
-
- //set the current manager
- if (session != null)
- session.setManager(this);
- else
- session = new ReplicatedSession(this);
+ Session session = new ReplicatedSession(this);
// Initialize the properties of the new session and return it
session.setNew(true);
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
