I agree that session recycling can be a security problem but am concerned that removing recycling will significantly increase GC overhead. I would like to see some before and after GC data from testing where 1000's of sessions get used per hour. Testing with different versions of the JVM would be needed since GC performance varies a great deal between JVM's.
Regards,
Glenn
Remy Maucherat wrote:
Hi,
I'd like to completely remove session recycling code from TC 5, as it is a potentially dangerous feature (which has been disabled in TC 4.1.x) and does not bring any actual performance improvement while using memory.
The biggest impact of the change is the removal of the recycled array list for base manager, which can break existing TC 4 managers. OTOH, using that is unsafe, and fixing an affected manager is very easy (just remove whatever recylcling code was used).
I plan to keep Session.recycle around (nulling out references can help GC, esp since there could be a lot of session objects - with all their children - waiting to be GCed).
Comments ?
Remy
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
