Bill Barker wrote:

----- Original Message ----- From: "Remy Maucherat" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Monday, September 22, 2003 10:31 PM
Subject: Re: [PROPOSAL] Narrow down the list of JARs to be scanned for TLDs





Jan Luehe wrote:


Currently, any JARs in the classloader delegation chain of a webapp's
classloader are scanned for packaged TLDs. This is convenient, as it
allows a JAR-packaged taglib to be simply dropped in common/lib and
shared by all webapps, rather than requiring each webapp to bundle the
taglib in its own WEB-INF/lib.

However, scanning all available JARs for TLDs is not very efficient,
especially if the names of the JAR-packaged taglibs are known in
advance.

The proposal is to add a configurable String property ("tldJarNames")
on Context, which specifies the comma-separated list of JAR file names
(without any path info) that must be scanned for TLDs.

Catalina will continue to traverse the classloader delegation chain,
but only consider those JARs that match the names in the
comma-separated list.

If a JAR appears more than once in the classloader delegation chain,
we will pick its first occurrence.

If the "tldJarNames" property is not set, Catalina will continue to scan
all JARs in the classloader delegation chain for TLDs.

Comments?


Same as Yoav. -0. much pain, no gain.



Seeing as how it's already been committed, +0.



Has it? I saw some commits in the area of jar scanning, but not this one.



As Jan has already pointed out, it should improve the startup time for Tomcat 5 (since scanning TLD files is a major hit).

I too agree that limiting the number of jars scanned could substantially improve first start performance, however I am worried that the solution as suggested by Jan will make it too easy for the users to shoot themselves to the foot. Also, unless the user does some manual setup, there will be no performance gain,right? So wouldn't it be better to have a hardcoded list of well-known jar files that should be excluded from scanning? This would include all jars found in the Tomcat installation.

I also think that under no circumstances the jar files in WEB-INF/lib should be excluded from scanning, as that is in conflict with the spec.

Or is there something I am missing about the proposal?

Petr




Remy


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]






------------------------------------------------------------------------


This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments.


In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail.



------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to