----- Original Message ----- 
From: "Remy Maucherat" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Sunday, November 16, 2003 2:34 AM
Subject: Re: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5
CoyoteConnector.java CoyoteRequest.java LocalStrings.properties


> Bill Barker wrote:
> > I'm -1 on this.  It gives the Servlet no indication that anything is
wrong,
> > and leaves junk in the input stream for the next keep-alive request.  I
> > think that it would be better to handle this in the Adaptor's
> > postParseRequest method.
>
> I disagree: the problem with this is that we allocate one array right
> away based on content-length, not that there's a big upload (which is
fine).
>

The Adaptor can check for this:
  if("POST".equalsIgnoreCase(request.getMethod()) &&
     "application/x-www-form-urlencoded".equals(contentType) &&
     request.getContentLength() > connector.getMaxPostSize()) {
          response.setStatus(413);
          response.setMessage("POST Body exceeds maximum");
          return false;
   }


> Obviously, keep-alive is not an option in that case (and Tomcat will
> attempt to swallow any remaining output).
>
> Remy
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to