Günter Knauf a écrit :

IMHO, this is wrong.  The server port isn't necessarily the port being
listened on.  See bug report and patch, long ignored:


http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16901

ok, but its as wrong as before - my patch doesnt change the behaviour from what I see, and this is what I can find in the httpd-2.1 sources too in order to work with APR 1.0 because apr_sockaddr_port_get() was removed. I dont know for what reasons the patch you point to isnt applied yet; and I agree with you that it is better to correct the behaviour than change from wrong to wrong; so I'd suggest that you create another patch and post it here, and hope that it will be accepted by those who have commit rights, just as I do...

In JK 1.2.x for Apache 2 we're using :


s->server_name = (char *)ap_get_server_name(r);

...

    apr_sockaddr_port_get(&port,r->connection->local_addr);
    s->server_port = port;


Do you agree with this, if so I'll do the same for jk2



--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to