----- Original Message ----- From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, March 16, 2004 2:13 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java MappingData.java
Bill Barker wrote: >> Since from section 3.3 of the JSP spec, jsp-property-groups are translation >> time mappings, the only "clean" solution I can see would be to implement >> something like the TC 3.3 JspInterceptor (obviously, changed to a JspValve >> :) that would handle the pre-compilation checks with the required >> jsp-property-group applied. This would still be bending the spec a bit, but >> not as much as this patch does. > > Jan's solution seems unfortunately the least worst (my favorite by far > is to not fix anything): the problem is that with TC > 4 (I know, this > sucks), the valve will not be invoked for request dispatching :( > Point taken. One other possibility would be to go the whole route to JspInterceptor, and have a JspListener (which is much more like how JspInterceptor is implemented, than like JspValve). This would listen for a (new) MAPPING_EVENT to handle the translation phase of the JSP if necessary. Of course, the best solution would be for the JSR-152 expert group to issue an Errata clearing this up :). > So, patatras, it becomes much slower and much more complex (the valve > has access to the lower level stuff, while the RD does not). I suppose a > filter-like algorithm wouldn't be too bad (works on Strings without GC), > but it's another mapping operation and additional complexity (I believe > the mapping rules have subtle differences :) ). > > :( :( :( > > I suppose it's when implementing specs completely that you uncover > issues, and this is quite bad :( > > Rémy > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
