Hi Yoav,
I just give it try and it didn't work. I still see
thousands of opened '/dev/urandom' with lsof:
java 8457 webserver 19r CHR 1,9
39427 /dev/urandom
java 8457 webserver 20r CHR 1,9
39427 /dev/urandom
java 8457 webserver 21r CHR 1,9
39427 /dev/urandom
java 8457 webserver 22r CHR 1,9
39427 /dev/urandom
java 8457 webserver 23r CHR 1,9
39427 /dev/urandom
java 8457 webserver 24r CHR 1,9
39427 /dev/urandom
java 8457 webserver 25r CHR 1,9
39427 /dev/urandom
java 8457 webserver 26r CHR 1,9
39427 /dev/urandom
java 8457 webserver 27r CHR 1,9
39427 /dev/urandom
java 8457 webserver 28r CHR 1,9
39427 /dev/urandom
java 8457 webserver 29r CHR 1,9
39427 /dev/urandom
java 8457 webserver 30r CHR 1,9
39427 /dev/urandom
java 8457 webserver 31r CHR 1,9
39427 /dev/urandom
java 8457 webserver 32r CHR 1,9
39427 /dev/urandom
java 8457 webserver 33r CHR 1,9
39427 /dev/urandom
java 8457 webserver 34r CHR 1,9
39427 /dev/urandom
java 8457 webserver 35r CHR 1,9
39427 /dev/urandom
java 8457 webserver 36r CHR 1,9
39427 /dev/urandom
I think the leak is on 'new FileInputStream(f)' and
not is randomIS.
Thanks again.
--- [EMAIL PROTECTED] wrote:
> yoavs 2004/08/31 07:07:54
>
> Modified:
> catalina/src/share/org/apache/catalina/session
> ManagerBase.java
> Log:
> Added explicit close of randomIS DataInputSource
> for better resource handling.
>
> Revision Changes Path
> 1.32 +14 -1
>
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java
>
> Index: ManagerBase.java
>
>
===================================================================
> RCS file:
>
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
> retrieving revision 1.31
> retrieving revision 1.32
> diff -u -r1.31 -r1.32
> --- ManagerBase.java 16 Aug 2004 09:31:05 -0000
> 1.31
> +++ ManagerBase.java 31 Aug 2004 14:07:54 -0000
> 1.32
> @@ -452,6 +452,12 @@
> if( log.isDebugEnabled() )
> log.debug( "Opening " +
> devRandomSource );
> } catch( IOException ex ) {
> + try {
> + randomIS.close();
> + } catch (Exception e) {
> + log.warn("Failed to close
> randomIS.");
> + }
> +
> randomIS=null;
> }
> }
> @@ -728,6 +734,13 @@
> } catch( Exception ex ) {
> }
> devRandomSource=null;
> +
> + try {
> + randomIS.close();
> + } catch (Exception e) {
> + log.warn("Failed to close
> randomIS.");
> + }
> +
> randomIS=null;
> }
> Random random = getRandom();
>
>
>
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> For additional commands, e-mail:
> [EMAIL PROTECTED]
>
>
_______________________________
Do you Yahoo!?
Win 1 of 4,000 free domain names from Yahoo! Enter now.
http://promotions.yahoo.com/goldrush
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
