Hi, I might take a stab at this later today, using my first approach: "secure" will become an attribute of the ProtocolHandler interface. The Connector will retain its getSecure/setSecure methods, but they'll just pass through to the ProtocolHandler. That way the attribute will only be in one place and persisted once.
Yoav Shapira Millennium Research Informatics >-----Original Message----- >From: Remy Maucherat [mailto:[EMAIL PROTECTED] >Sent: Wednesday, September 22, 2004 10:24 AM >To: Tomcat Developers List >Subject: Re: Bugzilla 30936: secure attribute is persisted twice > >Peter Rossbach wrote: > >> Hey, >> >> we have many duplicate attributes at connector and protocolhandler >> classes- >> I have spent a lot of time to fix that at my new >> server.xml/context.xml storage >> module. >> Current design based on factory model with external description file >> to handle those issues. >> Very strange, but my only chance to implement the handler, without >> break the current codebase. >> >> We must refactor the Connector/Protocoll class to make a clear cut, >> between old and correct attributes. We drop maxProcessors and >> minProcessors attributes as example. > >Yes, we need to remove any useless field. More generally, the idea in >this branch is to remove anything useless. > >> My current questions are: >> Why we handle all connectors attributes as real class attributes >> and dymamic properties? >> Can we drop the attribute translation between Connector and >> ProtocolHandler? > >No, we likely can't, because accessing them would become slow, and some >are used during request processing (so they need to remain fields on the >Connector class). > >Rémy > > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
