I'd like to kick off a detailed round of codereview for my changes
to webrev in preparation for final approach and putback. Thanks to
the folks who have offered suggestions and help thus far. Here's a
summary of the new features:
- "Just works" mode when you run it as 'webrev'
- Common color scheme and visual design
- Produces patch of changes (compatible with gpatch)
- Produces PDF review materials
- "OpenSolaris" mode
- Delta comments at the top of each file
- Printing support via media=print stylesheets
- Support for generating webrev against previous webrev
- Overhauled command line parsing including new options:
-o <outputdir>
-i <includefile>
-p <compare-against>
-W [use wx]
-O [OpenSolaris mode]
- Cleaned up and improved index.html page.
- Much improved man page
- XHTML compliance (or close)
- (Hopefully) ready for multiple-SCM support
This wad represents a pretty substantial overhaul of the code, so I would
appreciate one or two folks undertaking a detailed review.
http://cr.grommit.com/~dp/webrev.3/
I would also encourage tools-discuss folks to pull down the changes and
try them out on their own workspaces. This will hopefully help us all
build confidence about the code.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
tools-discuss mailing list
[email protected]