On Wed 04 Oct 2006 at 06:32PM, Will Fiveash wrote:
> > 1137: nit: suggest "$@" instead of $* here.
>
> I agree.
Fixed.
> > 4791-4796,5243: this doesn't feel right. Why wouldn't this be just:
> >
> > webrev) wx_webrev "$@"
> > shift $#;;
>
> I think he did that because wx pokes around in the args at 4799 and
> after that does a series of checks to make sure things are properly
> initialized. args, after wx sets it, are not suitable for webrev but
> the init checks should be done. No doubt wx could be refactored (in
> many places) but for now I think Dan's logic is okay. However I see
> something that Dan did not change but should and that is:
Yes. Exactly.
> 4785 orig_args="$*"
>
> should be:
>
> 4785 orig_args="$@"
Fixed.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
tools-discuss mailing list
[email protected]
