#21039: Refactor and simplify guard code of circuit_send_next_onion_skin()
---------------------------------+------------------------------------
Reporter: asn | Owner:
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-guard, refactor | Actual Points:
Parent ID: #20822 | Points: 0.3
Reviewer: | Sponsor:
---------------------------------+------------------------------------
Comment (by ordex):
A potential solution for this ticket has been implemented and uploaded on
guthub in my "ticket21039" branch (5 patches in total):
https://github.com/ordex/tor/commits/ticket21039 .
The branch is based on the current master.
On top of what the ticket is asking, I also tried to simplify and restyle
circuit_send_next_onion_skin() as a whole.
In the last patch I implemented a new unittest for the
circuit_send_next_onion_skin() function. However, being this my first
experience with the tor unittest code, I am not sure I did it right :)
feedback is welcome!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21039#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
