#21039: Refactor and simplify guard code of circuit_send_next_onion_skin() -------------------------------------------------+------------------------- Reporter: asn | Owner: ordex Type: defect | Status: | needs_review Priority: Medium | Milestone: Tor: | 0.3.1.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-guard, refactor, review- | Actual Points: group-16 | Parent ID: #20822 | Points: 0.3 Reviewer: asn | Sponsor: -------------------------------------------------+-------------------------
Comment (by asn): Hello, one thing that makes this patch quite hard to review in depth is that commit `bfbf516` moves _and_ edits code in the same commit. It would have been much easier to review if the commit was splitteed into two: one commit that only moves code, and a second commit that edits the moved code to fit the new codebase. Let me know if you are willing to do this change to ease review. For a more hands-on comment, this cast in the unittests is sketchy: {{{ static guard_usable_t mock_entry_guard_succeeded(circuit_guard_state_t **guard_state_p) { return **(guard_usable_t **)guard_state_p; } }}} Those two objects have nothing in common. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21039#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs