#21625: Review networking code for Firefox 52 -------------------------------------------------+------------------------- Reporter: gk | Owner: | mikeperry Type: task | Status: | assigned Priority: Very High | Milestone: Component: Applications/Tor Browser | Version: Severity: Critical | Resolution: Keywords: TorBrowserTeam201703, ff52-esr, | Actual Points: tbb-7.0-must | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by mikeperry): Components that could probably use another review: * The NetworkInfoService (./netwerk/base/NetworkInfoServiceCocoa.cpp and ./netwerk/base/NetworkInfoServiceLinux.cpp) both collect a list of local IP addresses for use in nsNetworkInfoService::ListNetworkAddresses(). This is used by mDNS and the Presentation API. Did I miss any uses? Maybe we want to patch this out just in case? * media/mtransport/nr_socket_prsock.cpp is an alternate non-SOCKS socket API. It should be disabled by WebRTC, but if Mozilla removed the compile- time WebRTC option, this definitely needs a double-check that it is not used. * netwerk/base/ThrottleQueue.cpp uses what appear to be local sockets for timer notification. Could use a double-check. * On Android, the uses of ch.boye.httpclientandroidlib.impl.client.* should be verified again. * The full git diff from esr45 to esr52 of ./android/ should probably be reviewed by someone with more Android development experience than me, for additional networking calls. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21625#comment:7> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs