#21625: Review networking code for Firefox 52 -------------------------------------------------+------------------------- Reporter: gk | Owner: | mikeperry Type: task | Status: | assigned Priority: Very High | Milestone: Component: Applications/Tor Browser | Version: Severity: Critical | Resolution: Keywords: ff52-esr, tbb-7.0-must-alpha, | Actual Points: TorBrowserTeam201705 | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by gk): Replying to [comment:7 mikeperry]: > Components that could probably use another review (Part 3/3): > * The NetworkInfoService (./netwerk/base/NetworkInfoServiceCocoa.cpp and ./netwerk/base/NetworkInfoServiceLinux.cpp) both collect a list of local IP addresses for use in nsNetworkInfoService::ListNetworkAddresses(). This is used by mDNS and the Presentation API. Did I miss any uses? Maybe we want to patch this out just in case? Sounds like a good idea to me. This is: #22165. > * media/mtransport/nr_socket_prsock.cpp is an alternate non-SOCKS socket API. It should be disabled by WebRTC, but if Mozilla removed the compile-time WebRTC option, this definitely needs a double-check that it is not used. Marked for `ff59-esr` (#22166). > * netwerk/base/ThrottleQueue.cpp uses what appear to be local sockets for timer notification. Could use a double-check. This looks actually okay to me. It got implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=1244227, for dev tools as an option to simulate crappy networks. > * On Android, the uses of ch.boye.httpclientandroidlib.impl.client.* should be verified again. #22170 > * The full git diff from esr45 to esr52 of ./android/ should probably be reviewed by someone with more Android development experience than me, for additional networking calls. #22171 -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21625#comment:15> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs