#21642: Prop275: Eliminate "published" times from microdescriptor consensus ------------------------------------------------+-------------------------- Reporter: nickm | Owner: nickm Type: enhancement | Status: | needs_revision Priority: Medium | Milestone: Tor: | 0.3.1.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: TorCoreTeam201703, review-group-17 | Actual Points: .5 Parent ID: | Points: 2 Reviewer: | Sponsor: Sponsor4 ------------------------------------------------+-------------------------- Changes (by dgoulet):
* status: needs_review => needs_revision Comment: lgtm; One quick comment: In `routerstatus_format_entry()`, this is used if not vote status is present: {{{ format_iso_time(published, rs->published_on_to_format); }}} This matches the commit description which is that `published_on_to_format` is only used has an output for the control port. However, I think we should add a strong validation of that and possibly a `tor_assert(format == NS_CONTROL_PORT)` in that if? If not, at least add a comment on how that is used for that function and what the caller should expect? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21642#comment:13> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs