#22210: circuit_is_acceptable is slow due to IP and fingerprint parsing --------------------------+------------------------------------ Reporter: teor | Owner: Type: defect | Status: new Priority: Medium | Milestone: Tor: 0.3.2.x-final Component: Core Tor/Tor | Version: Tor: 0.2.8.12 Severity: Normal | Resolution: Keywords: tor-hs | Actual Points: Parent ID: | Points: 1 Reviewer: | Sponsor: --------------------------+------------------------------------
Comment (by arma): Replying to [comment:1 arma]: > {{{ > const int family = tor_addr_parse(&addr, conn->socks_request->address); > }}} It looks like we could pretty easily only do that tor_addr_parse call in the two places below it where we would actually use the value of family -- that is, * (a) for a one-hop circuit where we've set chosen_exit_name and we don't have a digest for the exit, which should be rare if it ever happens, and * (b) when origin_circ->prepend_policy is set, meaning we've already received a surprising exit policy failure on that circuit and called adjust_exit_policy_from_exitpolicy_failure() on it. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22210#comment:2> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs