#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-------------------------------------------------+-------------------------
Reporter: teor | Owner: neel
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: prop224, tor-hs, single-onion, | Actual Points:
ipv6, 034-triage-20180328, |
034-removed-20180328 |
Parent ID: #23493 | Points: 1
Reviewer: teor | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
I ran make test-network-all on this branch, using the latest chutney
master. I am seeing come code pass, but some failures from this branch. I
also saw some HS failures (#24610) and bridge failures (#27080).
So I am not sure if the code in https://github.com/torproject/tor/pull/256
works. It also doesn't have any unit tests. (All the other
fascist_firewall_choose_address*() functions have unit tests.)
We need to be careful about our address parsing code, because it is a
source of security and anonymity issues.
I don't think we can merge this branch until the bugs are fixed:
{{{
$ make test-network-all
mkdir -p ./test_network_log
ping6 ::1 or ping ::1 succeeded, running IPv6 flavors: bridges+ipv6-min
ipv6-exit-min hs-v23-ipv6-md single-onion-ipv6-md.
tor-stable found, running mixed flavors: mixed+hs-v23.
PASS: basic-min
FAIL: bridges-min
PASS: hs-v2-min
PASS: hs-v3-min
PASS: single-onion-v23
FAIL: bridges+ipv6-min
FAIL: ipv6-exit-min
FAIL: hs-v23-ipv6-md
Detail: chutney/tools/warnings.sh /Users/base/chutney/net/nodes.1533778119
Warning: Bug: 0 tor
0x0000000100c53a2c log_backtrace_impl + 76 (on Tor 0.3.5.0-alpha-dev
dc06393aac4a459c) Number: 1
Warning: Bug: 1 tor
0x0000000100c44177 tor_bug_occurred_ + 503 (on Tor 0.3.5.0-alpha-dev
dc06393aac4a459c) Number: 1
Warning: Bug: 10 tor
0x00000001006e2c57 do_main_loop + 2423 (on Tor 0.3.5.0-alpha-dev
dc06393aac4a459c) Number: 1
Warning: Bug: 11 tor
0x00000001006e763b tor_run_main + 779 (on Tor 0.3.5.0-alpha-dev
dc06393aac4a459c) Number: 1
Warning: Bug: 12 tor
0x0000000100848451 tor_main + 161 (on Tor 0.3.5.0-alpha-dev
dc06393aac4a459c) Number: 1
Warning: Bug: 13 tor
0x00000001006433db main + 27 (on Tor 0.3.5.0-alpha-dev dc06393aac4a459c)
Number: 1
Warning: Bug: 14 libdyld.dylib
0x00007fff54fbe015 start + 1 (on Tor 0.3.5.0-alpha-dev dc06393aac4a459c)
Number: 1
Warning: Bug: 2 tor
0x0000000100965f1e hs_client_dir_info_changed + 206 (on Tor 0.3.5.0-alpha-
dev dc06393aac4a459c) Number: 1
Warning: Bug: 3 tor
0x00000001009b9b9c networkstatus_set_current_consensus + 9740 (on Tor
0.3.5.0-alpha-dev dc06393aac4a459c) Number: 1
Warning: Bug: 4 tor
0x00000001008fcdc1 connection_dir_client_reached_eof + 20913 (on Tor
0.3.5.0-alpha-dev dc06393aac4a459c) Number: 1
Warning: Bug: 5 tor
0x00000001008f79cf connection_dir_reached_eof + 143 (on Tor 0.3.5.0-alpha-
dev dc06393aac4a459c) Number: 1
Warning: Bug: 6 tor
0x00000001006c4114 connection_handle_read + 11668 (on Tor 0.3.5.0-alpha-
dev dc06393aac4a459c) Number: 1
Warning: Bug: 7 tor
0x00000001006d9978 conn_read_callback + 88 (on Tor 0.3.5.0-alpha-dev
dc06393aac4a459c) Number: 1
Warning: Bug: 8 libevent-2.1.6.dylib
0x00000001016269c2 event_process_active_single_queue + 1057 (on Tor
0.3.5.0-alpha-dev dc06393aac4a459c) Number: 1
Warning: Bug: 9 libevent-2.1.6.dylib
0x0000000101623cb3 event_base_loop + 1074 (on Tor 0.3.5.0-alpha-dev
dc06393aac4a459c) Number: 1
Warning: Bug: Non-fatal assertion !(status == HS_CLIENT_FETCH_HAVE_DESC)
failed in retry_all_socks_conn_waiting_for_desc at
../src/feature/hs/hs_client.c:275. Stack trace: (on Tor 0.3.5.0-alpha-dev
dc06393aac4a459c) Number: 1
Warning: Every introduction point for service
p2qpw3p725i6dspcw5yxy7zltrqulp4dnspfza3quiasro3rgx2yabid is unusable or we
can't extend to it. We can't connect. Number: 8
Warning: Not enough info to open a circuit to a rendezvous point for
hidden service p2qpw3p725i6dspcw5yxy7zltrqulp4dnspfza3quiasro3rgx2yabid.
Number: 1
Warning: tor_bug_occurred_: Bug: ../src/feature/hs/hs_client.c:275:
retry_all_socks_conn_waiting_for_desc: Non-fatal assertion !(status ==
HS_CLIENT_FETCH_HAVE_DESC) failed. (on Tor 0.3.5.0-alpha-dev
dc06393aac4a459c) Number: 1
PASS: single-onion-ipv6-md
PASS: mixed+hs-v23
Detail: chutney/tools/warnings.sh /Users/base/chutney/net/nodes.1533778259
Warning: Unable to add signatures to consensus: Mismatched digest. Number:
20
Log and result files are available in ./test_network_log.
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
