#23588: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs() -------------------------------------------------+------------------------- Reporter: teor | Owner: neel Type: defect | Status: | needs_revision Priority: Medium | Milestone: Tor: | 0.3.5.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: prop224, tor-hs, single-onion, | Actual Points: ipv6, 034-triage-20180328, | 034-removed-20180328 | Parent ID: #23493 | Points: 1 Reviewer: teor | Sponsor: -------------------------------------------------+-------------------------
Comment (by teor): > I do have a question: where should I put the BUG() warning when there's no reachable address? hs_get_extend_info_from_lspecs() is a good place to check if the address and port returned by fascist_firewall_choose_address_ls() are valid. (You can use tor_addr_port_is_valid() to check ap.) In future, when we make other functions call hs_get_extend_info_from_lspecs(), they might want to do different checks. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588#comment:33> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs