#29734: Broker should receive country stats information from Proxy and Client -------------------------------------+------------------------------ Reporter: cohosh | Owner: cohosh Type: enhancement | Status: needs_review Priority: Medium | Milestone: Component: Obfuscation/Snowflake | Version: Severity: Normal | Resolution: Keywords: snowflake, geoip, stats | Actual Points: Parent ID: #29207 | Points: 1 Reviewer: | Sponsor: Sponsor19 -------------------------------------+------------------------------
Comment (by ahf): I think this looks good, with a few comments/questions: - I don't think we should include the two geoip databases in the repository by default? - We should make the path to the two GeoIP databases configurable (either via a command line parameter and/or a small config file?) - I don't know if this is a common thing in Go code to do, but in many functional languages where you have type aliases people tend to do type aliases for `string` types to make them "more specific". In this case the country-string type could be called `Country` so the metrics table would be a mapping of a Country to a monotonically increasing counter. - What should we do with these values when they are here? Should we have an API end-point that can dump them? Should we save them to a log file with some heartbeat interval? Chelsea Komlo showed me a neat library for collecting internal metrics in Go applications, but it might be too early to introduce additional dependencies just for this. It was this library: https://github.com/armon/go-metrics -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29734#comment:8> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs