#29209: Reduce visibility of more data type internals ----------------------------------------+---------------------------------- Reporter: nickm | Owner: (none) Type: task | Status: needs_review Priority: Medium | Milestone: Tor: | 0.4.1.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: technical-debt refactoring | Actual Points: 3.5 Parent ID: | Points: 15 Reviewer: nickm | Sponsor: Sponsor31-can ----------------------------------------+----------------------------------
Comment (by asn): Thanks for all the info! Here is an attempt to accomplish the hiding of `crypto` using the macro concept from above: https://github.com/torproject/tor/pull/982 Things that might need improvement but I would like feedback on: - Right now, I named the privatization macro as `TOR_PRIV()` so that it's generic and can be used by other modules, however it's currently hidden in `crypt_path_st.h`. Do you like the name? And where should I put it? - I named the access macro `pvt_crypto`. I went for the agnostic `pvt`, but perhaps according to comment:11 I should have gone with some module- specific name? Like `cp_crypto` for `crypt_path`? Any other preferences? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29209#comment:13> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs