#29209: Reduce visibility of more data type internals ----------------------------------------+---------------------------------- Reporter: nickm | Owner: (none) Type: task | Status: needs_review Priority: Medium | Milestone: Tor: | 0.4.1.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: technical-debt refactoring | Actual Points: 3.5 Parent ID: | Points: 15 Reviewer: nickm | Sponsor: Sponsor31-can ----------------------------------------+----------------------------------
Comment (by nickm): This strategy looks good! Also, let's change the identifier so that it's more clearly not reserved; I'm not sure that the `## _ ## _private` trick is actually any more legal than `##__private`. Instead let's use something like `x ## _MODULE_NAME_private_field` maybe? The `pvt` version is fine with me. If this is going to be a shared macro, lib/cc seems like a decent place for it, but I'm not sure we want to use this same macro everywhere: I think we'd like to mangle member names differently depending on which module owns them. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29209#comment:14> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs